Fix for Sql-Psi SqlCoreEnvironment #710
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
sql-psi
breaks SqlDelight - main reason is thatlocalFileSystem
,jarFileSystem
were private.Make
localFileSystem
,jarFileSystem
protected as they are inherited properties in SqlDelight.Unless there is some reason due to Isolation for these to be private ?
Fix SqlDelight fixture tests with
file.toAbsolutePath
as the relative path breaks all tests in SqlDelight.Note:
SqlDelight will require some minor changes to take this
sql-psi
version as it is not a compatible version, that will be done once this new version is published and can be tried out.This
sql-psi
was tested in SqlDelight by updatingsettings.gradle
Integration tests are independent builds so need a different relative path for
settings.gradle
CHANGELOG.md
's "Unreleased" section has been updated, if applicable.