-
Notifications
You must be signed in to change notification settings - Fork 139
Add "sidebar-theme" in Shell Top-level parameters #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, I missed that! Could we use the global theme by default, make this accept the same values as the theme parameter (instead of being a boolean), and use an underscore in the name? For the documentation, can you please open a pull request? |
I'm open to a new pr to add a separate, documented, sidebar_theme, which falls back to the main theme when not specified :) |
Mmmm, I didn't put the sidebar-theme to fallback into the main theme! Instead, what I wanted is the possibility to have the sidebar in dark theme and the rest of the app in light theme. Before the change, the behaviour was: What do you think about? |
Ok, that's okay for me. But let's name it sidebar_theme (snake case), and have people set it to "dark", not any truthy value. Can you make a PR with the changes to the code and the docs? |
Hi,
Currently, the documentation of shell component only states about sidebar:

But when the sidebar component was created, we have included a "sidebar-theme" for letting people have "both" theme websites:
I guess the card with the info should be something like:
sidebar-theme (Boolean, optional)
When used with the "sidebar" propery, it enables the dark theme only on the sidebar.
The text was updated successfully, but these errors were encountered: