Skip to content

Add "sidebar-theme" in Shell Top-level parameters #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ajotah98 opened this issue Aug 16, 2024 · 4 comments
Closed

Add "sidebar-theme" in Shell Top-level parameters #540

Ajotah98 opened this issue Aug 16, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Ajotah98
Copy link
Contributor

Hi,

Currently, the documentation of shell component only states about sidebar:
image

But when the sidebar component was created, we have included a "sidebar-theme" for letting people have "both" theme websites:

image

I guess the card with the info should be something like:

sidebar-theme (Boolean, optional)

When used with the "sidebar" propery, it enables the dark theme only on the sidebar.

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 16, 2024

Oh, I missed that! Could we use the global theme by default, make this accept the same values as the theme parameter (instead of being a boolean), and use an underscore in the name?

For the documentation, can you please open a pull request?

lovasoa added a commit that referenced this issue Aug 17, 2024
#540

@Ajotah98 : I'm open to a new pr to add a separate, documented, sidebar_theme, which falls back to the main theme when not specified
@lovasoa
Copy link
Collaborator

lovasoa commented Aug 17, 2024

I'm open to a new pr to add a separate, documented, sidebar_theme, which falls back to the main theme when not specified :)

@lovasoa lovasoa added the enhancement New feature or request label Aug 17, 2024
@Ajotah98
Copy link
Contributor Author

Mmmm, I didn't put the sidebar-theme to fallback into the main theme! Instead, what I wanted is the possibility to have the sidebar in dark theme and the rest of the app in light theme.

Before the change, the behaviour was:
if not sidebar-theme -> sidebar light, app light
if theme (global) -> sidebar dark, also app dark
if sidebar-theme (but not theme = dark) -> sidebar dark, app light

What do you think about?

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 19, 2024

Ok, that's okay for me. But let's name it sidebar_theme (snake case), and have people set it to "dark", not any truthy value. Can you make a PR with the changes to the code and the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants