Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gorutine leaks #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix gorutine leaks #324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a256e81
fix: goroutine leaks. And don't execute defer in for loops
zhayt Mar 16, 2024
5977fa2
refactor: use the GET and POST constants of the http library
zhayt Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/ocsp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func fetchOCSP(cert, issuer *x509.Certificate) ([]byte, error) {
}

body, err := io.ReadAll(resp.Body)
defer resp.Body.Close()
resp.Body.Close()
if err != nil {
lastError = err
continue
Expand All @@ -162,7 +162,7 @@ func fetchOCSP(cert, issuer *x509.Certificate) ([]byte, error) {
}

func buildOCSPwithPOST(server string, encoded []byte) (*http.Request, error) {
req, err := http.NewRequest("POST", server, nil)
req, err := http.NewRequest(http.MethodPost, server, nil)
if err != nil {
return nil, err
}
Expand All @@ -179,7 +179,7 @@ func buildOCSPwithGET(server string, encoded []byte) (*http.Request, error) {
// GET {url}/{url-encoding of base-64 encoding of the DER encoding of the OCSPRequest}
url := fmt.Sprintf("%s/%s", server, base64.StdEncoding.EncodeToString(encoded))

req, err := http.NewRequest("GET", url, nil)
req, err := http.NewRequest(http.MethodGet, url, nil)
if err != nil {
return nil, err
}
Expand Down