Allow password-protected CAs to call revoke command #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #110
We test this in workflow_test.go, which is an integration test. We check to make sure that calling revoke does not result in any errors.
I also added password as a flag to the revoke command (mainly for integration testing purposes - this is a common pattern in workflow_test.go).
Manual Testing: I ran go build for certstrap so that I can run certstrap with the updates in this PR - the successful case is with the Alice cert, and the failure case (i.e. we fail to supply the passphrase when revoking) with Bob):