This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Jeversmann/kochiku yml updates #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| def create_working_dir | ||
| FileUtils.mkdir_p(WORKING_DIR) | ||
| def read_from_repo(file_name, repository, ref="HEAD") |
There was a problem hiding this comment.
I don't see this method being called from anywhere
There was a problem hiding this comment.
I wrote it for the kochiku.yml but since there were multiple locations to check it needed to be more specific; I left it in planning to use it to clean up code which was making assumptions about inside_copy.
I'll probably trim out all of the Thread stuff after changing kochiku.yml in response to your comment there.
|
Updated in response to feedback. |
| self.save! | ||
| if !promoted? | ||
| BuildStrategy.promote_build(self) | ||
| Build.where(id: self.id, promoted: nil).each { |build| build.update!(promoted: true) } |
There was a problem hiding this comment.
All that is needed here is:
update!(promoted: true)
The build being updated is self.
|
Fixed the |
jeversmann
added a commit
that referenced
this pull request
Jul 11, 2014
Jeversmann/kochiku yml updates
robolson
added a commit
that referenced
this pull request
Oct 29, 2015
* commit '9bd4c1f94a07243b1136916e9832e3e9ac3e7fa4': Fix pressing Return key will update the dashboard page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes build enqueueing logic so that test command, on success script, and log file targets from kochiku.yml. I also moved the logic for interacting with the GitRepos around to eliminate cases where methods were making assumptions about how they were being called.