This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Remove ability to update a tag on success #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For those of you not following along 'run_ci' means start builds on pushes to the master branch (which Kochiku receives notice of via web hooks).
* increase the width of the label area * make the checkbox rows just as tall as the text fields (28px)
This was originally added to allow developers to choose between updating a tag or updating a branch with the latest green ref on the master branch. In retrospect, using tags for this is terrible since they are not ment to be updated.
|
LGTM |
|
Looks good to me (and I learned something about git which I hadn't really thought about too much, see http://stackoverflow.com/questions/1457103/what-is-the-difference-between-a-tag-and-a-branch-in-git for more discussion). |
Shenil
added a commit
that referenced
this pull request
Oct 29, 2015
… master * commit '0b7496f89078d68c7296b54303705249e35fa5d4': Add metrics dashboard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use_branches_on_green column from repositories and defaults the behavior to updating a branch. This options was originally added to allow developers to choose between updating a tag or updating a branch with the latest green ref on the master branch. In retrospect, using tags for this is terrible since they are not meant to be updated.
This PR also contains a few style changes to the repository edit form.
@square/kochiku-contributors