This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
Pass a build if it is aborted and all of its parts succeed #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote to call no other methods besides the one under test making it a more pure unit test.
Fixes an unexpected outcome where a build is marked as aborted even if all of its build parts have passed. This can happen if a build is aborted after all of its build attempts already started executing and those build attempts all go on to pass.
|
Clean code! LGTM. |
| @@ -104,8 +106,8 @@ def update_state_from_parts! | |||
| end | |||
|
|
|||
| previous_state = self.state | |||
| update_attributes!(:state => state) | |||
| [previous_state, state] | |||
| update_attributes!(:state => next_state) unless previous_state == next_state | |||
There was a problem hiding this comment.
Not really a big deal, but wouldn't rails dirty tracking give you the "unless" for free?
There was a problem hiding this comment.
I had thought so too but I tested it in console and an UPDATE still occurred. I tried both updated_attributes! and save!.
There was a problem hiding this comment.
OK, there's probably something unusual here, or something I don't understand, but it doesn't seem necessary to figure it out.
|
Looks good to me. |
robolson
added a commit
that referenced
this pull request
May 15, 2014
Pass a build if it is aborted and all of its parts succeed R: squarenerd jkingdon
robolson
added a commit
that referenced
this pull request
Oct 29, 2015
* commit '8e4103811f5b98ee677cb91d0602dac1b24deaf3': SqFork: Move all background jobs to be monitored by runit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to avoid the confusing situation where a build is aborted after all of its build attempts have started and those build attempts go on to succeed but the build remains in the aborted state. With this change, a build will switch for aborted to succeeded in that situation.
@cheister @squarenerd