Jeversmann/success mail #89
Conversation
| mail :to => @emails, | ||
| :bcc => Settings.kochiku_notifications_email_address, | ||
| :subject => "[kochiku] #{@build.project.name} pull request approved", | ||
| :from => "#{email_user}+#{@build.project.name.parameterize}@#{email_domain}" |
There was a problem hiding this comment.
I think it makes sense to just use sender_email_address as is. At minimum it should be repository name instead of project name but I think I'd rather have neither. We can change the build_break_email to match.
|
Missing option at the repository level to control whether build success emails get sent. |
|
|
||
| def build_success_email(build) | ||
| @build = build | ||
| @emails = GitBlame.emails_in_branch(@build) |
There was a problem hiding this comment.
Does it make sense to send the success email to every person who has a commit on the branch?
Ideally we would notify the person who submitted the PR or the developer build but we do not actually have that information.
In lieu of that I think the best thing we can do is notify the person who has the most recent commit on the branch.
|
I went ahead and changed all of the GitBlame methods to use committer instead of author. |
| expect(email.html_part.body).to include(build_part.project.name) | ||
| expect(email.text_part.body).to include(build_part.project.name) | ||
| expect(email.html_part.body).to include("http://") | ||
| expect(email.text_part.body).to include("http://") |
There was a problem hiding this comment.
I don't really think these last 4 expects provide any value.
There was a problem hiding this comment.
They're there to be consistent with the content of the other BuildMailer specs, and I don't think it's worth removing them from all of the descriptions.
|
LGTM to me. Let's clean up the commits before merging. |
|
Rebased onto master after #91 was merged. |
…specialness to master * commit 'd75c163e865cdfe16134d31a1df7190affd13c34': fix typo remove maven partitioner special case for the all-protos/protos git subtree
Sends build success emails when developer builds and pull requests pass.