Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moshi 1.14.x updates #1550

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Moshi 1.14.x updates #1550

merged 6 commits into from
Sep 6, 2022

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Jun 24, 2022

  • Update Kotlin to 1.7.0
  • Update KotlinPoet to 1.12.0
  • No longer shade kotlinpoet-ksp APIs
  • Update to KSP 1.7.0-1.0.6
  • Update kotlinx-metadata to 0.5.0, allowing reading of kotlin 1.8 APIs too

@ZacSweers ZacSweers requested a review from swankjesse June 24, 2022 04:11
@ZacSweers ZacSweers marked this pull request as ready for review June 24, 2022 04:15
@yogurtearl
Copy link
Contributor

yogurtearl commented Jun 27, 2022

This is branched from 1.13.x, so 1.14.x won't have all the changes that are in the 1.14.0-SNAPSHOT builds being published from master, which could be a bit unexpected for some.

Might want to mention that in the 1.14 release notes.
Also, might consider switching the SNAPSHOT's from master to be 2.0.0-SNAPSHOT :)

@yogurtearl
Copy link
Contributor

as an example, this reified adapter method is in the current 1.14.0-SNAPSHOT but not in this branch.

public inline fun <reified T> adapter(): JsonAdapter<T> = adapter(typeOf<T>())

@yogurtearl
Copy link
Contributor

yogurtearl commented Jun 28, 2022

FWIW, I built/tested the branch locally and this branch works for us with Kotlin 1.6.21, Compose 1.2.0-rc02, which need the updated ksp/kotlinpoet versions.

@ZacSweers
Copy link
Collaborator Author

This PR wouldn't merge to main, it would just be branching from 1.13 and be used to make a 1.14 release with all the above updates. 2.0 is what's happening on main and still needs a bit of work

@yogurtearl
Copy link
Contributor

This PR wouldn't merge to main, it would just be branching from 1.13 and be used to make a 1.14 release with all the above updates. 2.0 is what's happening on main and still needs a bit of work

Yeah, that is what makes it a bit expected that main is publishing 1.14.0-SNAPSHOT and not 2.0.0-SNAPSHOT

fixed here: #1552

@mmasny-nemo
Copy link

Hello, have you planned the 1.14 release for any specific date yet?

@ZacSweers
Copy link
Collaborator Author

nope

@yogurtearl
Copy link
Contributor

yogurtearl commented Jul 27, 2022

FWIW, we have an internal fork with the changes in this PR applied and it is working well for us. :)

@t1u1
Copy link

t1u1 commented Aug 1, 2022

We tried out the new API and it works great!

@swankjesse swankjesse merged commit 2b879c4 into moshi_1.14.x Sep 6, 2022
@swankjesse swankjesse deleted the z/1114Updates branch September 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants