Make the DNS service pluggable. #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2015
Closed
| @@ -30,44 +30,57 @@ | |||
| * this is the server's hostname and port. If an explicit proxy is requested (or | |||
| * {@linkplain Proxy#NO_PROXY no proxy} is explicitly requested), this also includes | |||
| * that proxy information. For secure connections the address also includes the | |||
| * SSL socket factory and hostname verifier. | |||
| * SSL socket factory, hostname verifier and certificate pinner. | |||
|
LGTM |
It was already pluggable as the internal class named Network. Now it's exposed as a public interface called DNS.
swankjesse
force-pushed
the
jwilson_1103_custom_dns
branch
from
0745e4b to
38c6e61
Compare
swankjesse
added a commit
that referenced
this pull request
Nov 4, 2015
Make the DNS service pluggable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already pluggable as the internal class named Network. Now it's
exposed as a public interface called DNS.