Drop code for Android 2.3 through 4.4. #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more Gingerbread, Honeycomb, Ice Cream Sandwich, Jelly Bean or KitKat.
|
Nice to see the new years PRs are back! |
swankjesse
commented
Jan 1, 2019
| public BasicCertificateChainCleaner(TrustRootIndex trustRootIndex) { | ||
| this.trustRootIndex = trustRootIndex; | ||
| public BasicCertificateChainCleaner(X509Certificate... caCerts) { | ||
| subjectToCaCerts = new LinkedHashMap<>(); |
There was a problem hiding this comment.
Promoted from BasicTrustRootIndex.
| @@ -112,13 +128,31 @@ private boolean verifySignature(X509Certificate toVerify, X509Certificate signin | |||
| } | |||
| } | |||
|
|
|||
| /** Returns the trusted CA certificate that signed {@code cert}. */ | |||
| private X509Certificate findByIssuerAndSignature(X509Certificate cert) { | |||
|
|
JakeWharton
approved these changes
Jan 1, 2019
|
When you update http://square.github.io/okhttp/ with requirements, can you call out the ongoing support for critical security updates for 3.12.X? But that it won't be generally active. It would be good to be able to point people to our documented policy (whatever specifically that is). |
yschimke
reviewed
Jan 1, 2019
| @@ -50,8 +46,6 @@ | |||
| private final Class<?> sslParametersClass; | |||
There was a problem hiding this comment.
"Android 2.3 or better" above
There was a problem hiding this comment.
Snuck in a fix here: #4511
|
Maybe worth logging a warning when this code runs on older platforms as guidance when a developer runs on a legacy device. Is that easy to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more Gingerbread, Honeycomb, Ice Cream Sandwich, Jelly Bean or KitKat.