Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the unused DistinguishedNameParser. #4990

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

swankjesse
Copy link
Collaborator

This hasn't been used since we stopped supporting CN verification in
#3764.

This hasn't been used since we stopped supporting CN verification in
#3764.
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we need to crank up error-prone's unused checks

@swankjesse
Copy link
Collaborator Author

Tough to do mechanically ’cause it's covered by tests. Only hint is it's an internal class not reachable by non-internal classes.

@JakeWharton
Copy link
Collaborator

JakeWharton commented Apr 28, 2019 via email

@swankjesse swankjesse merged commit 8b55ef0 into master Apr 28, 2019
@oldergod oldergod deleted the jwilson.0428.dn_parser_dead branch May 7, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants