OkHttpClientTestRule check connectionCount instead of idle #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clients should be clean after use, not just from idle connections.
|
hmmm... maybe can't land without some fixes, probably a good sign? |
|
Interesting! |
yschimke
commented
Jun 25, 2019
| @@ -84,6 +84,7 @@ | |||
| clientListener.assertExhausted(); | |||
|
|
|||
| // TODO: assert all connections are released once leaks are fixed | |||
| clientTestRule.abandonClient(client); | |||
There was a problem hiding this comment.
The comment above makes it clear why this test was failing...
The rule is still worth using here to standardise the test client creation, but we just don't end up with clean client instances.
yschimke
commented
Jun 25, 2019
| val connectionPool = prototype!!.connectionPool | ||
| connectionPool.evictAll() | ||
| assertThat(connectionPool.idleConnectionCount()).isEqualTo(0) | ||
| prototype?.let { |
There was a problem hiding this comment.
using let over simple if check because of a mutable field
swankjesse
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients should be clean after use, not just from idle connections.