Be more consistent with task names #5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Oct 6, 2019
| @@ -48,7 +48,7 @@ package okhttp3.internal.concurrent | |||
| */ | |||
| abstract class Task( | |||
| val name: String, | |||
| val cancelable: Boolean = true | |||
There was a problem hiding this comment.
I moved the default value to TaskQueue.schedule(). (I don’t like repeating the defaults; I find that hard to reason about.)
swankjesse
force-pushed
the
jwilson.1006.task_names
branch
from
9aa6c5c to
38d1d04
Compare
Examples: - OkHttp TaskRunner - MockWebServer TaskRunner - OkHttp ConnectionPool - MockWebServer localhost applyAndAckSettings - OkHttp android.com applyAndAckSettings - OkHttp android.com onSettings - OkHttp awaitIdle - OkHttp localhost I'm trying to use type names where appropriate, or method names otherwise. Names include hostname and stream name if the task is working on behalf of a specific stream or connection.
swankjesse
force-pushed
the
jwilson.1006.task_names
branch
from
38d1d04 to
4ec26dc
Compare
oldergod
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
I'm trying to use type names where appropriate, or method names otherwise.
Names include hostname and stream name if the task is working on behalf
of a specific stream or connection.