Defer EventListener events until bytes are returned #5670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Dec 30, 2019
| eventSequence.clear() | ||
| while (eventSequence.isNotEmpty()) { | ||
| takeEvent() | ||
| } |
There was a problem hiding this comment.
What's the difference here?
There was a problem hiding this comment.
I need to call takeEvent() so the lastTimestampNs is updated.
| assertTrue(noCloses) | ||
| } else { | ||
| fail("close without open") | ||
| } |
There was a problem hiding this comment.
I think this is just
assertTrue("close without open", noCloses)There was a problem hiding this comment.
yep, thanks. (I exploded that into 5 lines to set breakpoints and forgot to roll back!)
swankjesse
force-pushed
the
jwilson.1230.time_to_first_byte
branch
2 times, most recently
from
1eea6e2 to
a1cf78f
Compare
This changes the timing of responseHeaderStart and responseBodyStart events to fire when bytes are received from the server. This is a non-trivial behavior change and should be documented as such in the release notes. In particular, the responseFailed event may be fired without a preceding responseHeadersStart event. To test this I've added a timestamp to our CallEvent test facet. Closes: #5578
swankjesse
force-pushed
the
jwilson.1230.time_to_first_byte
branch
from
a1cf78f to
53d2d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the timing of responseHeaderStart and responseBodyStart events to
fire when bytes are received from the server. This is a non-trivial behavior
change and should be documented as such in the release notes. In particular,
the responseFailed event may be fired without a preceding responseHeadersStart
event.
To test this I've added a timestamp to our CallEvent test facet.
Closes: #5578