Add tests for multiple routes #7563
Conversation
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
|
|
||
| @Flaky |
There was a problem hiding this comment.
Is this due to raciness in fast fallback? I wonder if we can add something to make it less racy, like changing the timeouts to MAX_VALUE or 0 or something
There was a problem hiding this comment.
Sorry, not Flaky. I'm just using it for logging the tracing.
| .assertBody("body") | ||
|
|
||
| assertThat(client.routeDatabase.failedRoutes).isEmpty() | ||
| // TODO check if we expect a second request to server1, before attempting server2 |
There was a problem hiding this comment.
(I think that’s the behavior we should test for, though we could create an issue and change that)
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.extension.RegisterExtension | ||
|
|
||
| @Flaky |
There was a problem hiding this comment.
Is this due to raciness in fast fallback? I wonder if we can add something to make it less racy, like changing the timeouts to MAX_VALUE or 0 or something
| } | ||
| } | ||
|
|
||
| class SpecificHostSocketFactory( |
There was a problem hiding this comment.
Promote to its own file?
There was a problem hiding this comment.
This is a great idea BTW
Test for IPv4, IPv6 multiple routes. When the RouteDatabase is updated, how many follow up requests are made.