Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linuxArm64 target #1301

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

bcmedeiros
Copy link
Contributor

Closes #1171

This is a draft compiling okio for linuxArm64.
Pending:

  • Release of kotlinx-datetime, this draft is using a local snapshot from main.

@bcmedeiros
Copy link
Contributor Author

If anyone from JetBrains is seeing this, a release from kotlinx-datetime would be very appreciated.

Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do not merge until there’s a kotlinx-datetime release

@bcmedeiros bcmedeiros marked this pull request as ready for review September 1, 2023 10:30
@bcmedeiros
Copy link
Contributor Author

@swankjesse I think this is ready for review and merge now.

okio/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "X64" from the filename.

bcmedeiros and others added 2 commits September 1, 2023 19:40
@bcmedeiros
Copy link
Contributor Author

Done, @JakeWharton, let me know if you need anything else adjusted!

@JakeWharton JakeWharton enabled auto-merge (squash) September 1, 2023 11:46
@JakeWharton JakeWharton merged commit 746cacc into square:master Sep 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add linuxArm64 and Arm32 variants
3 participants