Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Drawables in -night Resource Directories Still Does Not Work #2105

Closed
Bleach13J opened this issue Sep 9, 2019 · 7 comments
Closed
Assignees
Milestone

Comments

@Bleach13J
Copy link

I saw a couple of tickets about this issue and they were all marked as closed and the answer given says the removal of with(context) fixed this issue.

I am currently trying to use the latest version of this library with resources from any -night resource directory and non of them are being loaded. It is still defaulting to the -nontnight directories.

I have tried setting the app to night mode before calling Picasso.get() in case the order mattered and it did not.

Please take a look at this and see if a fix can be pushed out. If not then i'll either have to have doubles of all my drawables with the night and day versions or find another library that can handle this.

I really like Picasso and would hate to have to stop using it but I really need it to be able to work with night mode.

Thanks

@jrodbx jrodbx self-assigned this Sep 9, 2019
@jrodbx jrodbx added this to the 3.0 milestone Sep 9, 2019
@JakeWharton
Copy link
Collaborator

Dupe of #1275. I'm not sure we ever claimed the removal of with(Context) fixed the issue, but rather unblocks the ability to change the behavior.

@Bleach13J
Copy link
Author

So is there a solution at all that fixes this issue?

@JakeWharton
Copy link
Collaborator

JakeWharton commented Sep 12, 2019 via email

@Bleach13J
Copy link
Author

As of right now I'm using boolean logic to determine if I'm in night mode and then load a different image in if I use picasso instead of the app determining which resource qualifier it should be using to pull drawable resources.

It should be able to work the same as when it determines what resolution image to pull whether it be mdpi, hdpi, etc.

@Bleach13J
Copy link
Author

Will 3.0 fix this issue by chance?

@jrodbx
Copy link
Collaborator

jrodbx commented Sep 12, 2019

Assigned #1275 to me and added it to the 3.0 release milestone.

@Bleach13J
Copy link
Author

Thanks guys for the quick responses. You have been very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants