wrap Activity and Compose rules in LeakCanary checks on both sides

[RBusarow]

I'm open to bike-shedding the name. 😄

fixes #657

[RBusarow]

The actual rule is just above the fold, so GitHub won't let me comment on the line I'm interested in...

workflow-kotlin/workflow-ui/internal-testing-android/src/main/java/com/squareup/workflow1/ui/internal/test/DetectLeaksAfterTestSuccess.kt

Lines 29 to 36 in 72ba8c7

	try {
	base.evaluate()
	LeakAssertions.assertNoLeaks(tag)
	} finally {
	// Otherwise upstream test failures will be reported as leaks.
	// https://github.com/square/leakcanary/issues/2297
	AppWatcher.objectWatcher.clearWatchedObjects()
	}

If we're executing this twice per test, do we want to skip the call to clearWatchedObjects() the first time?

[rjrjr]

I have no idea. @py?

[pyricau]

No, should be fine. But maybe use clearAfter timestamp instead

[pyricau]

 try { 
   base.evaluate()
   val heapDumpUptimeMillis = SystemClock.uptimeMillis()
   LeakAssertions.assertNoLeaks(tag) 
 } finally { 
   // Otherwise upstream test failures will be reported as leaks. 
   // https://github.com/square/leakcanary/issues/2297 
   AppWatcher.objectWatcher.clearObjectsWatchedBefore(heapDumpUptimeMillis) 
 } 

[RBusarow]

I made this change -- thanks!

[vgonda]

LGTM

But I'm just learning about all this, so you probably want another 👍

[pyricau]

One thing to note: all the changes here (and in internal forks of the rule) have been backported to LeakCanary which will soon be released as 2.9. You'll need to adapt the code a bit but should be able to delete this custom rule.

https://github.com/square/leakcanary/blob/main/leakcanary-android-instrumentation/src/main/java/leakcanary/DetectLeaksAfterTestSuccess.kt

[rjrjr]

@RBusarow Any plans to update this to LC 2.9 and get it merged?

[RBusarow]

@RBusarow Any plans to update this to LC 2.9 and get it merged?

Yeah, I'll get this updated soon. I took a stab at it a while ago and was running into leaks in the compose activity rule, but didn't have the time to dig into it.