Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Rename compose method and concept in docs to render #266

Closed
zach-klippenstein opened this issue Apr 11, 2019 · 1 comment · Fixed by #301
Closed

[swift] Rename compose method and concept in docs to render #266

zach-klippenstein opened this issue Apr 11, 2019 · 1 comment · Fixed by #301
Assignees
Labels
enhancement New feature or request points: 1
Milestone

Comments

@zach-klippenstein
Copy link
Collaborator

The compose function was originally called render in the Swift implementation. After much discussion, we decided to rename to compose to avoid suggesting too strong an association with UI (it can return screen data, but can also be any arbitrary value).

However, this is dumb for a few reasons:

  • we're still calling the type Rendering
  • "render" is a much more specific verb to represent this specific concept than the super-generic "compose"
  • It turns out Swift never actually got around to renaming everything anyway.

For these reasons, I propose renaming the State{ful|less}Workflow.compose method back to render.

@qrazhan
Copy link
Contributor

qrazhan commented Apr 11, 2019

+1 compose is really abstract and only leads to more confusion when starting out IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request points: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants