Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WorkflowContext.compose/render method to composeChild/renderChild #267

Closed
zach-klippenstein opened this issue Apr 11, 2019 · 0 comments · Fixed by #274
Closed

Rename WorkflowContext.compose/render method to composeChild/renderChild #267

zach-klippenstein opened this issue Apr 11, 2019 · 0 comments · Fixed by #274
Labels
enhancement New feature or request kotlin Affects the Kotlin library. points: 1
Milestone

Comments

@zach-klippenstein
Copy link
Collaborator

It is confusing that both the method you implement (but never call!) and the context method that you call to trigger your children's method are called the same thing. It is difficult to distinguish in the docs, especially since we need to clearly communicate that the former should never be called directly.

To address this, we propose adding a Child suffix to the latter method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kotlin Affects the Kotlin library. points: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant