Optimize doesClassImplement performance by caching #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, much appreciated. Will backport the change and release new versions of AppleCore soon. |
leagris
added a commit
to Beyond-Reality/BeyondRealityModPack
that referenced
this pull request
Mar 18, 2017
Improve startup time by ~67% (thanks @asiekierka [squeek502/ASMHelper#13]) Fix sending way too many saturation/exhaustion sync packets on multiplayer servers Add exhaustion.sync.threshold config option to control the frequency of exhaustion sync packets Sync difficulty to each player on login (instead of only on server startup)
satoshinm
pushed a commit
to satoshinm/modpack
that referenced
this pull request
Jun 22, 2017
Improve startup time by ~67% (thanks @asiekierka [squeek502/ASMHelper#13]) Fix sending way too many saturation/exhaustion sync packets on multiplayer servers Add exhaustion.sync.threshold config option to control the frequency of exhaustion sync packets Sync difficulty to each player on login (instead of only on server startup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a modpack with just Forge and AppleCore, this makes AppleCore's ASM transformation time drop from ~900ms to ~300ms (a ~67% reduction); I expect similar amounts of reduction for larger kitchen sink modpacks where AppleCore takes up ~2000ms.