Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Meter/second bar #9

Open
VirtualEsence opened this issue Nov 9, 2017 · 4 comments
Open

The Meter/second bar #9

VirtualEsence opened this issue Nov 9, 2017 · 4 comments
Labels

Comments

@VirtualEsence
Copy link

In The Version 1.12.2 The Bar dont show UP
i ahve optifine and better pvp mod does that make the error of not thowing the bar?

@VirtualEsence
Copy link
Author

plz fix it :(

@squeek502
Copy link
Owner

Not really sure how to help you. If Squeedometer shows up in your mod list in game, then the only possibility I can think of is that some mod is blocking the Forge RenderGameOverlayEvent.Pre event that Squeedometer relies on (and if so, there's not much I can do about that afaik).

@squeek502 squeek502 added the bug label Nov 10, 2017
@squeek502
Copy link
Owner

squeek502 commented Nov 10, 2017

This seems to be an incompatibility with BetterPVP--that mod cancels the RenderGameOverlayEvent.PRE event for RenderGameOverlayEvent.ElementType.HOTBAR, which is what Squeedometer uses.

Not exactly sure what should be done to fix this; (talking to myself here), there are a couple options I see:

  • Change the priority of Squeedometer's RenderGameOverlayEvent handler so that it fires before BetterPVP cancels it
  • Stop checking for RenderGameOverlayEvent.ElementType.HOTBAR and use RenderGameOverlayEvent.ElementType.ALL instead
  • Swap RenderGameOverlayEvent.PRE for RenderGameOverlayEvent.POST, which can't be canceled (not sure if this should be done) POST is never fired if PRE is canceled for the given ElementType

@hohserg1
Copy link

hohserg1 commented Oct 4, 2022

You can use @SubscribeEvent(receiveCanceled = true) for process required event anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants