CI: Add OpenBSD build tests for staged commits #1964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinkie
commented
Dec 16, 2024
| metaauto | ||
|
|
||
| mkdir $HOME/bin | ||
| ln -s /usr/local/bin/ggrep $HOME/bin/grep |
There was a problem hiding this comment.
There are a bunch of GNUisms in our build chain
kinkie
commented
Dec 16, 2024
| run: | | ||
| export MAKE=gmake | ||
| export pjobs="-j`gnproc`" | ||
| export AUTOMAKE_VERSION=1.16 |
There was a problem hiding this comment.
OpenBSD support for multi-version automake is complicated
kinkie
commented
Dec 16, 2024
| export amver=${AUTOMAKE_VERSION} | ||
| export ACLOCAL_AUTOMAKE_DIR="/usr/local/share/aclocal-${AUTOMAKE_VERSION}" | ||
| export ACLOCAL_PATH="/usr/local/share/aclocal:/usr/local/share/aclocal-${AUTOMAKE_VERSION}" | ||
| export AUTOCONF_VERSION=2.72 |
kinkie
commented
Dec 16, 2024
| export ltver=2.4.2 | ||
| export CFLAGS='-Wno-compound-token-split-by-macro' | ||
| export LDFLAGS="-L/usr/local/lib" | ||
| export PATH="$HOME/bin:$PATH" |
There was a problem hiding this comment.
we need this to shadow the system 'grep' command
kinkie
changed the title
kinkie
changed the title
rousskov
requested changes
Dec 17, 2024
| export pjobs="-j`gnproc`" | ||
| export AUTOMAKE_VERSION=1.16 | ||
| export amver=${AUTOMAKE_VERSION} | ||
| export ACLOCAL_AUTOMAKE_DIR="/usr/local/share/aclocal-${AUTOMAKE_VERSION}" |
There was a problem hiding this comment.
Is there a similar hack that can avoid the following warnings?
aclocal-1.16: warning: couldn't open directory '/usr/bin/../share/aclocal': No such file or directory
There was a problem hiding this comment.
Not that I know of. OpenBSD is rough around the edges in these areas
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
kinkie
added
the
S-waiting-for-reviewer
rousskov
approved these changes
Dec 17, 2024
rousskov
added
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
Dec 18, 2024
Use a GitHub-hosted VM to create OpenBSD test environment. We have not enabled ccache optimization for OpenBSD tests because we do not know how to copy updated ccache files from VM back into runner.
squid-anubis
added
the
M-waiting-staging-checks
rousskov
removed
the
S-could-use-an-approval
squid-anubis
pushed a commit
that referenced
this pull request
Dec 20, 2024
Use a GitHub-hosted VM to create OpenBSD test environment. Requires GitHub repository configuration that permits the use of `vmactions/openbsd-vm@v1` Action. We have not enabled ccache optimization for OpenBSD tests because we do not know how to copy updated ccache files from VM back into runner.
|
GitHub reported "startup failure" for the staged commit c7e0a60. AFAICT, GitHub provided no failure details and probably did not report that odd failure to agents monitoring repository state (e.g., Anubis). Thus, this PR got stuck waiting for staging tests that are not running. I would expect a staged test to fail because our GitHub repository configuration did not allow |
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a GitHub-hosted VM to create OpenBSD test environment. Requires
GitHub repository configuration that permits the use of
vmactions/openbsd-vm@v1Action.We have not enabled ccache optimization for OpenBSD tests because we
do not know how to copy updated ccache files from VM back into runner.