Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 5091: document that changes to workers require restart #1980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug 5091: document that changes to workers require restart #1980

wants to merge 2 commits into from
+3 −0

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Jan 8, 2025

No description provided.

@kinkie kinkie added the backport-to-v6 maintainer has approved these changes for v6 backporting label Jan 8, 2025
@rousskov rousskov self-requested a review January 9, 2025 14:50
@rousskov rousskov added the S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box label Jan 13, 2025
@rousskov
fixup: Polished new paragraph wording
b8b5641 
* Avoid "Note:". This paragraph does not require special attention.
* Avoid "parameter" when talking about the directive as a whole.
* Spell out "reconfiguration" to improve discoverability.
* Do not imply a partial (i.e. not "full") Squid restart is relevant.
rousskov
rousskov approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this documentation! I polished the new paragraph a little, but I only insist on removing "Note:" and "full"; please adjust further as needed.

@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Jan 14, 2025
squid-anubis pushed a commit that referenced this pull request Jan 14, 2025
@kinkie @squid-anubis
Bug 5091: document that changes to workers require restart (#1980)
9e913fa
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 14, 2025
@squid-anubis squid-anubis removed the M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 15, 2025
squid-anubis pushed a commit that referenced this pull request Jan 15, 2025
@kinkie @squid-anubis
Bug 5091: document that changes to workers require restart (#1980)
83c501d
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadij yadij yadij approved these changes

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
backport-to-v6 maintainer has approved these changes for v6 backporting M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels S-waiting-for-author author action is expected (and usually required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinkie @rousskov @yadij @squid-anubis