Add regression testing for https_port ECDH parameter loading #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk-tls-test-certs.sh depends on receiving empty string instead of /bin/false when tools are unavailable
yadij
added
the
S-waiting-for-PR
|
Based on logic for certificate testing this requires PR #154 to merge first. |
rousskov
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Based on logic for certificate testing this requires PR #154 to merge first.
This PR contains PR 154 commits. Please close this PR (at least for now). If you want others to pre-review this PR changes in isolation from PR 154 changes, you may stack a PR on top of PR 154 changes in your Squid repository (GitHub does not support PRs stacked across forks). If you want others to use this PR code, they can already use your tls-testing-dh branch (without a PR).
rousskov
added
the
S-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.