Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: allow more flexibility in github release source fact for monorepos #3800

Closed
4 tasks done
jlipps opened this issue Apr 5, 2022 · 4 comments
Closed
4 tasks done
Labels
not fixable Issue concerns an unfixable bug

Comments

@jlipps
Copy link

jlipps commented Apr 5, 2022

Contribution guidelines

I want to suggest an idea and checked that ...

  • ... to my best knowledge, my idea wouldn't break something for other users
  • ... the documentation does not mention anything about my idea
  • ... there are no open or closed issues that are related to my idea

Description

Currently, source facts are derived from GitHub, including the current release. For monorepos, releases for multiple packages might be published to the same github repo. It would be nice to provide some kind of filtering mechanism to Material so that only releases matching a certain package or string or regex would be included in the source fact.

I encountered this issue while trying to make a new docs system for appium. The release tag which is shown is for a package unrelated to the one I am publishing docs for.

Use Cases

This would benefit monorepo users or those who might want flexibility over which release/tag is shown in the documentation (not simply the first returned by GitHub).

Screenshots / Mockups

Screen Shot 2022-04-05 at 11 33 15

@jlipps jlipps changed the title allow more flexibility in github release source fact for monorepos Feature request: allow more flexibility in github release source fact for monorepos Apr 5, 2022
@jlipps jlipps changed the title Feature request: allow more flexibility in github release source fact for monorepos Feature suggestion: allow more flexibility in github release source fact for monorepos Apr 5, 2022
@squidfunk
Copy link
Owner

Thanks for suggesting. I agree that more flexibility would be awesome, but sadly, GitHub's Latest Release endpoint will always return the latest release and doesn't allow for filtering. For a detailed explanation, see #2943 (comment)

Related:

@squidfunk squidfunk added the not fixable Issue concerns an unfixable bug label Apr 6, 2022
@jlipps
Copy link
Author

jlipps commented Apr 6, 2022

OK. Would it be possible to just have an option to not show any repo facts instead, or to show something custom? I guess it's possible to do this by creating an override, but I figure this might be a somewhat common issue.

@squidfunk
Copy link
Owner

squidfunk commented Apr 6, 2022

Hiding the tag is easy with a few lines of CSS, as noted in #2481 (comment). I'm not keen on adding another option which we'd have to hand over frommkdocs.yml to base.html to the JavaScript when the same is achievable with a few lines of CSS. Everything else can be customized via theme extension or some additional JavaScript.

@jlipps
Copy link
Author

jlipps commented Apr 6, 2022

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not fixable Issue concerns an unfixable bug
Projects
None yet
Development

No branches or pull requests

2 participants