Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few accessibility fixes from lighthouse report #1391

Merged
merged 10 commits into from
Dec 18, 2019
Merged

a few accessibility fixes from lighthouse report #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
802ae76
a few accessibility fixes from lighthouse report
Stanzilla Dec 18, 2019
356735b
add rel="noopener" to external links
Stanzilla Dec 18, 2019
b43233e
add title attribute to social links
Stanzilla Dec 18, 2019
fc0a1a7
add mimetype to manifest link and allow it to work behind auth
Stanzilla Dec 18, 2019
8dfd525
add font-display: swap to all the places where external fonts are used
Stanzilla Dec 18, 2019
4af3378
remove font-display: swap from icon fonts
Stanzilla Dec 18, 2019
a7a3f6a
removed font-display from style blocks in base
Stanzilla Dec 18, 2019
2aaa3ea
add target="_blank" to social links
Stanzilla Dec 18, 2019
c7d505f
switch base fonts grabbed from Google back to display:fallback
Stanzilla Dec 18, 2019
d6c8ba3
add target="_blank" to the footer links as well
Stanzilla Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/assets/stylesheets/base/_icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
line-height: 1;
text-transform: none;
white-space: nowrap;
speak: none;
word-wrap: normal;
direction: ltr;

Expand Down
2 changes: 1 addition & 1 deletion src/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@

<!-- Progressive Web App Manifest -->
{% if config.extra.manifest %}
<link rel="manifest" href="{{ config.extra.manifest | url }}">
<link rel="manifest" type="application/manifest+json" href="{{ config.extra.manifest | url }}" crossorigin="use-credentials">
{% endif %}

<!-- Custom stylesheets -->
Expand Down
4 changes: 2 additions & 2 deletions src/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@
</div>
{% endif %}
powered by
<a href="https://www.mkdocs.org">MkDocs</a>
<a href="https://www.mkdocs.org" target="_blank" rel="noopener">MkDocs</a>
and
<a href="https://squidfunk.github.io/mkdocs-material/">
<a href="https://squidfunk.github.io/mkdocs-material/" target="_blank" rel="noopener">
Material for MkDocs</a>
</div>

Expand Down
3 changes: 2 additions & 1 deletion src/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@
<div class="md-flex__cell md-flex__cell--shrink">
<a href="{{ config.site_url | default(nav.homepage.url, true) | url }}"
title="{{ config.site_name }}"
aria-label="{{ config.site_name }}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an ARIA label + the alt tag on the image - how is this handled by screen readers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows Narrator just says "sitename" once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And lighthouse complained about there missing a label to the a because the img inside of it was not enough, for whatever reason.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great, so this is ready to merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes from my side!

class="md-header-nav__button md-logo">
{% if config.theme.logo.icon %}
<i class="md-icon">{{ config.theme.logo.icon }}</i>
{% else %}
<img src="{{ config.theme.logo | url }}" width="24" height="24" />
<img alt="logo" src="{{ config.theme.logo | url }}" width="24" height="24" />
{% endif %}
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/partials/nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
{% if config.theme.logo.icon %}
<i class="md-icon">{{ config.theme.logo.icon }}</i>
{% else %}
<img src="{{ config.theme.logo | url }}" width="48" height="48" />
<img alt="logo" src="{{ config.theme.logo | url }}" width="48" height="48" />
{% endif %}
</a>
{{ config.site_name }}
Expand Down
2 changes: 1 addition & 1 deletion src/partials/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<label class="md-search__overlay" for="__search"></label>
<div class="md-search__inner" role="search">
<form class="md-search__form" name="search">
<input type="text" class="md-search__input" name="query"
<input type="text" class="md-search__input" aria-label="search" name="query"
placeholder="{{ lang.t('search.placeholder') }}"
autocapitalize="off" autocorrect="off" autocomplete="off"
spellcheck="false" data-md-component="query"
Expand Down
2 changes: 1 addition & 1 deletion src/partials/social.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<link rel="stylesheet" type="text/css"
href="{{ 'assets/fonts/font-awesome.css' | url }}" />
{% for social in config.extra.social %}
<a href="{{ social.link }}" class="md-footer-social__link
<a href="{{ social.link }}" target="_blank" rel="noopener" title="{{ social.type }}" class="md-footer-social__link
fa fa-{{ social.type }}"></a>
{% endfor %}
</div>
Expand Down