Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous *.js pattern for extra_javascript in schema.json #7150

Merged
merged 1 commit into from
May 3, 2024

Conversation

vorburger
Copy link
Contributor

Since mkdocs/mkdocs#92 for mkdocs/mkdocs#91, an extra_javascript item does not necessarily have to end in *.js; e.g. in enola-dev/enola#669 I have an extra_javascript: - https://unpkg.com/mustache@latest, which this flags up as wrong - although it's not (it works great); ergo it's better to remove this constraint.

Since mkdocs/mkdocs#92 for mkdocs/mkdocs#91, an extra_javascript item does not necessarily have to end in *.js; e.g. in enola-dev/enola#669 I have a extra_javascript: - https://unpkg.com/mustache@latest, which this flags up as wrong - although it's not (it works great); ergo it's better to remove this constraint.
@squidfunk
Copy link
Owner

Thanks for the PR. I would not call it erroneous, since the URL you use is not the final resolved URL – it's redirecting to the final URL which contains the .js extension. However, I agree that we can remove that restriction.

@squidfunk squidfunk merged commit b0c5fe6 into squidfunk:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants