Fix float precision issue in double pass #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If second pass is fill and we provide the fixed size from the first pass, it's possible fill doesn't return the same layout within those limits due to flex / float precision. Expanding the limits by 1 pixel appears to completely resolve this.
|
@andymandias mind testing this for the context menu bug? @tarkah cooked up a much better solution. |
|
Looks good, all context menus render as intended. |
casperstorm
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If second pass is fill and we provide the fixed
size from the first pass, it's possible fill doesn't return the same layout within those limits due to
flex / float precision. Expanding the limits by 1
pixel appears to completely resolve this.