Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help screen buttons are now correctly sized again #259

Merged
merged 2 commits into from
Mar 8, 2024
Merged

help screen buttons are now correctly sized again #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5414f46
fix: help screen buttons fill
casperstorm Mar 8, 2024
41ee25c
Update CHANGELOG.md
casperstorm Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Fix:

- Context menus now shows buttons as expected
- Buttons on help screen is now correctly sized

Security:

Expand Down
9 changes: 5 additions & 4 deletions src/screen/help.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use data::{config, Config};
use iced::widget::{button, column, container, row, text, vertical_space};
use iced::widget::{button, column, container, text, vertical_space};
use iced::{alignment, Length};

use crate::widget::Element;
Expand Down Expand Up @@ -43,15 +43,16 @@ impl Help {
.align_x(alignment::Horizontal::Center)
.width(Length::Fill),
)
.width(Length::Fill)
.width(Length::Fixed(250.0))
.style(theme::Button::Secondary)
.on_press(Message::OpenConfigurationDirectory);

let refresh_button = button(
container(text("Refresh"))
.align_x(alignment::Horizontal::Center)
.width(Length::Fill),
)
.width(Length::Fill)
.width(Length::Fixed(250.0))
.style(theme::Button::Secondary)
.on_press(Message::RefreshConfiguration);

Expand All @@ -64,7 +65,7 @@ impl Help {
.push(text(self.error.to_string()).style(theme::Text::Error))
.push(vertical_space(10))
.push(
row![]
column![]
.width(250)
.spacing(4)
.push(config_button)
Expand Down
Loading