Fix Solid nickname color

[neilalexander]

This was accidentally changed to the action color in #232.

[casperstorm]

Hmm, this was because the nicknames in chat was action if solid was selected, but nicknames in sidemenu was text. I think we should consider accent for both instead. With text it all blends too much together.

[neilalexander]

This is probably one of those subjective/theme-specific things — to my eyes, the "blending together" was what made the nick list disappear into the periphery rather than stand out too much. For example, this stands out quite a lot:

... whereas this felt more in-keeping to me with the rest of the theme:

Accent colour might be OK, it doesn't look as though it's used by much else apart from text selection?

Another alternative is that we put it to text and add some permanent alpha to it, so that it's subtly different but not by much, for example at alpha 0.6:

[casperstorm]

Colors are hard :)
Perhaps the solution is simply to do text.base for both nicklist and nicknames in buffer.
It will blend the most, which i assume people who use this option want.

I just think that colors: "solid" should provide the same color for nicklist and nicknames in buffer!

[neilalexander]

Right now there are separate colors: options for the buffer and nick list, so they can be controlled separately. That seems like a nice option to keep? Then you can have colours in the buffer but not nick list (like I do), both or neither.

Presumably both use the nickname() function?

[casperstorm]

Right now there are separate colors: options for the buffer and nick list, so they can be controlled separately. That seems like a nice option to keep? Then you can have colours in the buffer but not nick list (like I do), both or neither.

Presumably both use the nickname() function?

Correct, but initially the nickname color in the buffer was action and the colors in nicklist was text.
Then in main both is action, and this PR changes both to text. 😄

I am good with that, now that I've given it some thoughts.

[casperstorm]

What about:

    if seed.is_none() {
        let color = match transparent {
            true => theme.colors().text.med_alpha,
            false => theme.colors().text.base,
        };

        return Appearance { color: Some(color) };
    }

[neilalexander]

That's much nicer and more compact, will do that!

[casperstorm]

Could you also add a small line to CHANGELOG? Then it should be good to go.

[neilalexander]

Done!

[casperstorm]

Thanks a bunch @neilalexander