Timeout delay for notifications #665
Merged
+192
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
englut
force-pushed
the
main
branch
2 times, most recently
from
33c2486 to
d1882ab
Compare
englut
changed the title
englut
force-pushed
the
main
branch
3 times, most recently
from
40254e3 to
fcc4561
Compare
casperstorm
reviewed
Dec 19, 2024
englut
force-pushed
the
main
branch
2 times, most recently
from
9cbcd61 to
093e909
Compare
casperstorm
reviewed
Dec 20, 2024
casperstorm
reviewed
Dec 20, 2024
src/notification.rs
Outdated
| server, | ||
| ); | ||
| } | ||
| fn _execute( |
There was a problem hiding this comment.
No need for the underscore naming here, imo.
casperstorm
reviewed
Dec 20, 2024
casperstorm
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout delay for
direct messageall notifications to prevent multiple simultaneous messages flooding with notification sounds.Default is set to 500ms.
Addresses issue #600.
EDIT: Refactored for all notifications.
EDIT 2: I had looked into maybe turning
Notificationsinto a trait. But I don't think that's what traits are meant for. So I'll leave it for now. If anyone has any suggestions for refactors or improvements, I am open 🙏