Restructure build process to simplify the wasm memory fragmentation

[TrueDoctor]

Todo:

• js parsing
• fix bodged find function
• general cleanup
• use texture library instead of deprecated shared heap

[nat-rix]

Instead of of using a return-statement, use

if blah {
    Err(foo)
} else {
    Ok(bar)
}

[TrueDoctor]

no

[nat-rix]

why not?

[TrueDoctor]

because it does not make the cod any faster, shorter or more readable

[nat-rix]

Instead of using Index, you could use get (and get_mut in store) for indexing (self.0.get(id)), which returns an Option. That would be much cleaner than the index_check-function.

[TrueDoctor]

I disagree if the requested resource is out of bounds, an error should be raised, because it is unexpected behaviour. It is essentially a fancy panic.
And I don't like the approach of get_mut(), because with the current implementation we do all the wrapping in the library which would then needed to be done by the user.

[nat-rix]

Panic? I thought a panic could not occur in your function. I don't get your point. You could do something like

match self.0.get(id).ok_or(myerrorblahblah)? {
}

This does not make any difference for the user

[TrueDoctor]

It is also relevant, whether the error occured because of an out of bounds, or because of a resource type mismatch

[nat-rix]

Of course, but that does not change anything on my point. See, you could do the following:

unsafe fn get(&'a self, id: usize) -> Result<&'a $type, EngineError> {
    match self.0.get(id) {
        Some(Resource::$enum_type(value)) => Ok(&value),
        Some(_) => Err("Wrong resource type".into()),
        None => Err("Invalid resource id")
    }
}

[nat-rix]

why not?

[nat-rix]

Panic? I thought a panic could not occur in your function. I don't get your point. You could do something like

match self.0.get(id).ok_or(myerrorblahblah)? {
}

This does not make any difference for the user