Merge branch 'feature/file-getmethod-properties-allow-static-return-t…

…ype' of https://github.com/jrfnl/PHP_CodeSniffer
squizlabs · Jun 22, 2020 · 4c6f4be · 4c6f4be
2 parents ad0bfc2 + 7e24a44
commit 4c6f4be
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 0 deletions.
diff --git a/src/Files/File.php b/src/Files/File.php
@@ -1629,6 +1629,7 @@ public function getMethodProperties($stackPtr)
                 T_CALLABLE     => T_CALLABLE,
                 T_SELF         => T_SELF,
                 T_PARENT       => T_PARENT,
+                T_STATIC       => T_STATIC,
                 T_NS_SEPARATOR => T_NS_SEPARATOR,
             ];
 

diff --git a/tests/Core/File/GetMethodPropertiesTest.inc b/tests/Core/File/GetMethodPropertiesTest.inc
@@ -66,3 +66,10 @@ $result = array_map(
     static fn(int $number) : int => $number + 1,
     $numbers
 );
+
+class ReturnMe {
+    /* testReturnTypeStatic */
+    private function myFunction(): static {
+        return $this;
+    }
+}
diff --git a/tests/Core/File/GetMethodPropertiesTest.php b/tests/Core/File/GetMethodPropertiesTest.php
@@ -383,6 +383,29 @@ public function testArrowFunction()
     }//end testArrowFunction()
 
 
+    /**
+     * Test a function with return type "static".
+     *
+     * @return void
+     */
+    public function testReturnTypeStatic()
+    {
+        $expected = [
+            'scope'                => 'private',
+            'scope_specified'      => true,
+            'return_type'          => 'static',
+            'nullable_return_type' => false,
+            'is_abstract'          => false,
+            'is_final'             => false,
+            'is_static'            => false,
+            'has_body'             => true,
+        ];
+
+        $this->getMethodPropertiesTestHelper('/* '.__FUNCTION__.' */', $expected);
+
+    }//end testReturnTypeStatic()
+
+
     /**
      * Test helper.
      *