Variable $this must be lowercase, PHP is case sensitive for variables

squizlabs · Jan 6, 2020 · 6c9b326 · 6c9b326
1 parent 0a6c51e
commit 6c9b326
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php b/src/Standards/Squiz/Sniffs/Scope/StaticThisUsageSniff.php
@@ -75,7 +75,7 @@ public function processTokenWithinScope(File $phpcsFile, $stackPtr, $currScope)
             } else if ($tokens[$next]['code'] === T_ANON_CLASS) {
                 $next = $tokens[$next]['scope_closer'];
                 continue;
-            } else if (strtolower($tokens[$next]['content']) !== '$this') {
+            } else if ($tokens[$next]['content'] !== '$this') {
                 continue;
             }
 

diff --git a/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc b/src/Standards/Squiz/Tests/Scope/StaticThisUsageUnitTest.inc
@@ -108,4 +108,10 @@ $b = new class()
         }) {
         };
     }
+
+    public static function thisMustBeLowercase() {
+        $This = 'hey';
+
+        return $This;
+    }
 }