-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same-line inline annotations make phpcs remove comment marks, leading to invalid code #2011
Comments
I can't replicate this with any of the included standards. Are you able to let me know what standard or sniffs you are using so I can try and replicate? |
Just checking in to see if you can give me more info about your standard. |
I'm sorry for keeping you waiting. I minimized the error condition down to
which outputs
You can reproduce the problem by cloning https://github.com/melbings/CodeSnifferTest. |
Thanks for doing that. I was able to replicate this bug and determine that it has already been fixed in master. The fix for this bug will be released in version 3.3.0. While the bug report looks a little different, the fix was made as part of this report: #2006 Thanks again for taking the time to get that test case going - it made things really clear. |
Glad it's fixed - keep up the good work 👍 |
I recently noticed this probable bug - phpcs analyzes the following snippet...
... and removes the leading
/**
of the second inline annotation, thus making the code invalid:Unfortunately, I have not had time to analyze this in any more detail, so that I'm providing the full code snippets instead of simplifying the code beforehand.
The text was updated successfully, but these errors were encountered: