Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4: backfill T_BAD_CHARACTER #2588

Closed
jrfnl opened this issue Aug 20, 2019 · 2 comments
Closed

PHP 7.4: backfill T_BAD_CHARACTER #2588

jrfnl opened this issue Aug 20, 2019 · 2 comments

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Aug 20, 2019

Tokenizer:
token_get_all() will now emit a T_BAD_CHARACTER token for unexpected
characters instead of leaving behind holes in the token stream.

PHP 7.4 (re-)introduces the T_BAD_CHARACTER token which previously already existed in PHP, but was removed in PHP 7.0.

IMO, this token should be back-filled for the PHP versions missing it.

Refs:

@gsherwood
Copy link
Member

Thanks for letting me know about this. I've made the token available to all versions, although it's not going to appear in older versions so there wasn't anything else I could do with it.

@jrfnl
Copy link
Contributor Author

jrfnl commented Aug 25, 2019

Thanks. FYI: As far as I know it was a token which could appear in the token stream pre-PHP 7.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants