Space after brace and PSR-2

[Yumash]

Found a strange error in Jenkins

phpcs --report=full --standard=PSR2 ChecklistController.php

FILE: ...jobs/2report_dev/workspace/frontend/controllers/ChecklistController.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
...
 168 | ERROR | [x] Expected 1 space after closing brace; newline found

So i didn't found a word in PSR-2 about needing a space before newline. Maybe there's a bug that CS does not tract newline as a space?

[aik099]

Could you please attach (maybe in gist form) complete file, because I suspect something around that code might be affecting the final shown error.

[Yumash]

I pushed it here: https://github.com/Jumashev/test/blob/master/ChecklistController.php (no editing, just copied from one repo to another)

[gsherwood]

Read this: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#51-if-elseif-else

Specifically this bit:

and that else and elseif are on the same line as the closing brace from the earlier body.

PSR-2 requires a single space between the closing brace of the IF and the ELSE keyword. You need to write it like this:

if (...) {
    // code here
} else {
  // code here
}

In your code, the else keyword is on the line following the brace, not on the same line, hence the error message mentioning that newline it found. Does this clear things up?

[Yumash]

Feel ashamed, so sorry for inconvenience :)

But if i would like not to strictly follow the PSR-2 - is there any chance to add there some exclusions to CS like as for this case?

Thank you!

[aik099]

@jumashev that's where custom rulesets comes in. In there you can extend existing standards by adding/removing/tuning their sniffs or even completely create own standard.

[Yumash]

Great! Thank you!

[gsherwood]

These docs might help you get started: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Annotated-ruleset.xml