PSR2.ControlStructures.SwitchDeclaration does not handle if branches with returns

[Majkl578]

Consider the following code as an example:

<?php

switch ($foo) {
    case 1:
        if ($bar === 1) {
            return 1;
        } elseif ($bar === 2) {
            return 2;
        } else {
            return 3;
        }
    case 2:
        return 4;
}

Although the case 1 body always returns and thus is not fall-through, the error is generated: There must be a comment when fall-through is intentional in a non-empty case body.

[gsherwood]

I'm not sure how hard this will be to fix. I might be able to just look for ELSE statements directly inside the case and search for returns in there, but I would also have to recursively check other nested ELSE statements inside as well.

In the meantime, the most obvious suggestion would be to make the return explicit, which also adheres to the common no-else-return rule (or even the no-else and return-early rules) because the ELSE is technically unnecessary:

switch ($foo) {
    case 1:
        if ($bar === 1) {
            return 1;
        } elseif ($bar === 2) {
            return 2;
        }

        return 3;
    case 2:
        return 4;
}

[Majkl578]

I understand this is not easy to fix, one has to check all branches recursively. Explicit return is of course a solution, and also more clean. :)

By the way, this problem also applies to throw.

[dereuromark]

@Majkl578 Or continue; ;)
But yeah, one should probably avoid this kind of nesting, better to refactor into a sub-method here.

[gsherwood]

Fixed by PR #1363