Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new sniff Generic.PHP.DeclareStrictTypes #1771

Closed
wants to merge 12 commits into from
Closed

Added new sniff Generic.PHP.DeclareStrictTypes #1771

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cac6a67
Added new sniff Generic.PHP.DeclareStrictTypes
michalbundyra Dec 6, 2017
d17c657
Allow declare strict types in one line
michalbundyra Dec 6, 2017
7f35bf6
Changed default value for $linesBefore to 1
michalbundyra Dec 6, 2017
0053c65
DeclareStrictTypesSniff updates
michalbundyra Jan 31, 2018
3b0645a
Renamed properties
michalbundyra Mar 25, 2018
0b073f3
Simplify code as findEndOfStatement now works correctly
michalbundyra Mar 26, 2018
b9025ea
Removed `omitCommentWithTags` property
michalbundyra Mar 26, 2018
855f68c
Updated tests to cover all cases
michalbundyra Mar 26, 2018
6165428
Use $phpcsFile->numTokens instead of counting tokens
michalbundyra Mar 27, 2018
6e947af
Returns ($phpcsFile->numTokens + 1) when nothing else to process
michalbundyra Mar 27, 2018
69ad7d0
Changed format property to private
michalbundyra Jan 24, 2019
4cd331f
Updated year in copyright headers
michalbundyra Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Standards/Generic/Sniffs/PHP/DeclareStrictTypesSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ public function process(File $phpcsFile, $stackPtr)

$this->checkOtherDeclarations($phpcsFile, $next);

return (count($tokens) + 1);
return $phpcsFile->numTokens;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, elsewhere return ($phpcsFile->numTokens + 1) is used. Shouldn't really make a difference, but just thought I'd mention it for consistency sake.

}//end if
}//end if

Expand All @@ -323,7 +323,7 @@ public function process(File $phpcsFile, $stackPtr)
$phpcsFile->fixer->addContent($stackPtr, $this->format.$phpcsFile->eolChar);
}

return (count($tokens) + 1);
return $phpcsFile->numTokens;

}//end process()

Expand Down