Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable exact checking of multi-line chained method calls in Generic.WhiteSpace.ScopeIndent #2372

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Disable exact checking of multi-line chained method calls in Generic.WhiteSpace.ScopeIndent #2372

merged 1 commit into from
Apr 15, 2019

Conversation

pfrenssen
Copy link
Contributor

Fixes #2371

drupol
drupol approved these changes Jan 24, 2019
View reviewed changes
Copy link

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sounds good and works for us.

@valeryan valeryan mentioned this pull request Feb 1, 2019
Closed
@gsherwood gsherwood added this to the 3.5.0 milestone Apr 3, 2019
@gsherwood gsherwood merged commit 6e315f1 into squizlabs:master Apr 15, 2019
gsherwood added a commit that referenced this pull request Apr 15, 2019
@gsherwood
Changelog for #2372 (ref #2371)
e1dcba4
@gsherwood
Copy link
Member

Thanks for this PR - good idea

@dxvargas dxvargas deleted the disable-strict-indent-object-operator branch October 3, 2019 22:24
@dxvargas dxvargas restored the disable-strict-indent-object-operator branch October 3, 2019 22:25
@dxvargas dxvargas deleted the disable-strict-indent-object-operator branch October 3, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Disable exact checking of multi-line chained method calls in Generic.WhiteSpace.ScopeIndent
3 participants
@pfrenssen @gsherwood @drupol