Generic.WhiteSpace.ScopeIndent false positives with nested switch indentation and case fall-through

[klausi]

When you have a nested switch statement without break statements then the scope indent sniff gets confused. Here is a testcase to demonstrate the problem, I have not found a solution yet.

[gsherwood]

The problem is that the return statements are being run twice, closing the CASE statement (as they should) but also the containing SWITCH. That leaves the indent in a bit of a mess.

I think I've found the problem and I'm testing a fix now.

[gsherwood]

The sniff was checking the indent in front of the return statement in one loop, then checking the return statement itself in the next loop. This is fine, but it ended up closing the scope of the CASE statement twice, which actually closed the scope of the SWITCH statement the second time.

I've added a test case and a fix here: 802e6ef

Your test case is now passing for me, although it would still be great if you were able to test the fix as well.

Thanks for reporting this.

[klausi]

Thanks a lot Greg! I was trying to get into this sniff myself and thought closing the scope twice was correct, but your fix is working as intended!

[klausi]

And found another bug with this sniff, opened #2504