Autoload relative paths first to avoid confusion with files from the global include path #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th files from the global include path
|
Workaround we deployed for Coder: pfrenssen/coder#72 . We are just using a more unique autoload file name in the hopes that it does not get confused with other PHP files on the user's system. |
jrfnl
reviewed
Dec 7, 2019
gsherwood
reviewed
Dec 8, 2019
| // Try relative autoload paths first. | ||
| $relativePath = Util\Common::realPath(dirname($rulesetPath).DIRECTORY_SEPARATOR.$autoloadPath); | ||
|
|
||
| if ($relativePath !== false && is_file($$relativePath) === true) { |
There was a problem hiding this comment.
Double $ needs to be removed here. I'll do this while merging.
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Dec 8, 2019
|
Thanks a lot for this fix. |
|
Ah, very sorry for the double $. That's what I get for making last minute changes. Let me know If there is a good way to write a test for this. |
Not a problem at all :)
I don't have one right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: autoload files are confused with globally available files. See pfrenssen/coder#54
If you specify
<autoload>./autoload.php</autoload>in your ruleset.xml file then a completely different autoload.php file from your system might be executed, even although you specified a relative path.Steps to reproduce:
composer install./vendor/bin/phpcs --standard=./standard test.phpOutput:
PHP Parse error: syntax error, unexpected 'invalid' (T_STRING) in test_phpcs/autoload.php on line 3Which means the wrong autoload.php file was included.
Proposed solution: Try to include relative paths first, then try global paths.
Not sure how we can test this, any tips for that?