PHP tokenizer: add missing verbose message #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 2860 made a change to the tokenizer which changes the token type of an `fn` keyword (back) to `T_STRING` if it turns out not to be an arrow function. That change did not include a verbose message for tokenizer debugging. Fixed now.
|
Thanks. I was working in this part of the file but didn't notice this was missing. I ended up changing the message to be similar to the "positive" case. It was also printing out the internal |
|
Sounds good. I just realized at some point I'd not added that message and that it would probably be useful, so glad it's in the codebase now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2860 made a change to the tokenizer which changes the token type of an
fnkeyword (back) toT_STRINGif it turns out not to be an arrow function.That change did not include a verbose message for tokenizer debugging. Fixed now.