Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to fix ArrayDeclaration.SpaceBeforeComma if there is a comment in between #3074

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Do not attempt to fix ArrayDeclaration.SpaceBeforeComma if there is a comment in between #3074

merged 1 commit into from
Sep 21, 2020

Conversation

morozov
Copy link
Contributor

@morozov morozov commented Sep 1, 2020

Fixes #3065.

gsherwood added a commit that referenced this pull request Sep 21, 2020
@gsherwood
Changelog for #3065 (ref #3074)
38b487e
@gsherwood gsherwood merged commit 6804dbd into squizlabs:master Sep 21, 2020
@gsherwood gsherwood added this to the 3.5.7 milestone Sep 21, 2020
@gsherwood
Copy link
Member

Thanks a lot for the detailed bug report and the fix.

@morozov morozov deleted the issues/3065 branch September 21, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
3.5.7
Development

Successfully merging this pull request may close these issues.

Should not fix Squiz.Arrays.ArrayDeclaration.SpaceBeforeComma if comment between element and comma
2 participants
@morozov @gsherwood