Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow stdin fix to exit sucessfully #3541

Closed

Conversation

PierreAntoineGuillaume
Copy link

@PierreAntoineGuillaume PierreAntoineGuillaume commented Jan 30, 2022

When submitting a file to phpcbf from stdin, phpcbf always fails.

I propose to make it succeed (exit 0) when no errors were found, given that cbf has no direct concept of "non-fixable errors".

It would allow tools to swap content of a buffered file when exit code is non-zero, and discard if nothing has been fixed.

@gsherwood
Copy link
Member

Changing a return value would need to target a new major version (4.0 in this case), and that is already being tracked on issue #2898.

Thanks for taking the time to write this PR, but I'm going to close it as a proper plan of the exit codes need to be made so they all make sense together. If you have a proposal, please drop it on that other issue to keep the discussion going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants