Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for match() in OperatorSpacingSniff #3653

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

kukulich
Copy link
Contributor

No description provided.

@kukulich kukulich marked this pull request as ready for review August 24, 2022 19:20
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just one remark.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gsherwood gsherwood added this to the 3.7.2 milestone Sep 10, 2022
@gsherwood gsherwood changed the title Fixed false positives for match() in OperatorSpacingSniff False positives for match() in OperatorSpacingSniff Sep 10, 2022
gsherwood added a commit that referenced this pull request Sep 10, 2022
@gsherwood gsherwood merged commit 9370b00 into squizlabs:master Sep 10, 2022
@gsherwood
Copy link
Member

Thanks for fixing this. I found a similar error in Squiz.Formatting.OperatorBracket as a result.

@jrfnl
Copy link
Contributor

jrfnl commented Sep 10, 2022

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants