Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "static analysis" Composer keyword #3655

Closed
wants to merge 2 commits into from

Conversation

GaryJones
Copy link
Contributor

As per https://getcomposer.org/doc/04-schema.md#keywords by including "static analysis" as a keyword in the composer.json file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with composer require instead of composer require --dev. See composer/composer#10960 for more info.

As per https://getcomposer.org/doc/04-schema.md#keywords by including "static analysis" as a keyword in the `composer.json` file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with `composer require` instead of `composer require --dev`. See composer/composer#10960 for more info.
As per https://getcomposer.org/doc/04-schema.md#keywords by including "static analysis" as a keyword in the `composer.json` file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with `composer require` instead of `composer require --dev`. See composer/composer#10960 for more info.
@GaryJones
Copy link
Contributor Author

Errant comma on the first commit, so these can be rebased/squashed on merge.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Looks like a good improvement.

@jrfnl
Copy link
Contributor

jrfnl commented Sep 4, 2022

Note: (new) external standards which require PHPCS will also get prompted whether squizlabs/php_codesniffer was deliberately requested as require, not require-dev. IMO, that's fine. Maintainers of external standards can select to keep the package in require on the command-line prompt.

@gsherwood gsherwood added this to the 3.7.2 milestone Sep 10, 2022
gsherwood added a commit that referenced this pull request Sep 10, 2022
@gsherwood
Copy link
Member

Thanks for this. I did end up squashing them, hence no merged tag.

@gsherwood gsherwood closed this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants