-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
国产刮削修改,增强,新增 #73
国产刮削修改,增强,新增 #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一般函数定义之间应当空两行, 不过这个项目也没有样式约定, 我到时再格式化吧
# 其他非javdb网站取消强制输出该字段 | ||
if json_data_nfo['javdbid']: | ||
print(" <javdbid>" + json_data_nfo["javdbid"] + "</javdbid>", file=code) | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方不要改了, 本来应该用 mosaic
字段判断, 国产或欧美不输出, 其它 JP 影片均输出, 但是 mosaic
具体可能写入什么我都搞不清楚. 另外这个字段仅在 emby 中搭配插件才有实际作用, 所以留着也无妨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所有国产影片会强制输出该字段,既然对国产完全没有用处,所以觉得有点多余
这个应该是用户自己完成, 毕竟已经提供了多配置功能. 很多刮削网站我自己也没用过, 没法设计一套通用的预设 |
我以为作者既然能够解耦代码应该全局调试过,网站确实很多除非资深骨灰级爱好者和原始创建者,否则确实很多地方的逻辑不清楚为什么要这么设置,并且很多站点的特性不清楚,所以才想作者出面解决一下,预设的配置文件可以解决一些无需代码的功能性问题,既可以提高刮削成功率降低重复刮削又能减少学习使用成本,方便快速上手 |
其实这个项目最大的问题是没有写测试,即使网站变化也发现不了。 |
* Fix: write custom actor names to nfo file * Fix: nfo文件写入错误空格;手动设置演员写入nfo文件 * Fix: mmtv custom website;try more actor matching rules * Fix: not match unknown actor * Fix: madouqu custom website;more actor matching attempts * Fix: non-javdb site writes irrelevant searchid field * Chore: guochan data collation * Fix: 7mmtv get more extrafanart pics * Fix: madouqu subtle parameter adjustment * Fix: guochan crawlers remove useless characters; number recognition a… * Feat: add hscangku and cableav crawlers * Merge branch 'sqzw-x:master' into master * Fix: PR compliance revisions * Merge pull request #73 from kikiyou18/master * Opt: javdbid 输出逻辑
简单说明
国产刮削建议